Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Controller #615

Closed
bakinazik opened this issue Feb 22, 2022 · 11 comments
Closed

Notification Controller #615

bakinazik opened this issue Feb 22, 2022 · 11 comments
Labels
fix-available A fix to the issue is available in a new version

Comments

@bakinazik
Copy link

I can't see the notification controller when I pause or play the music. I only see the controller after changing the volume. Can you fix this issue?

resim

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 22, 2022

Are you using the shortcuts plugin?
If so, Is the Override MediaKeys option enabled?

@bakinazik
Copy link
Author

resim

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 22, 2022

Weird because it works for me. EDIT: im dumb and wrote that from memory

Can you check that you're actually using the normal media play/pause key?

In https://keycode.info/ it should show 179 (play/pause) when you click the button

Also what happens if you press next/previous mediakeys? Does it show that notification?

(176/177 keycodes)

@bakinazik
Copy link
Author

resim
resim

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 22, 2022

Windows only show the volume OSD when changing volume

so play/pause/next/previous wont show that OSD, its just windows behavior

you can search google for "Windows volume OSD" and see for yourself. so there isn't actually any bug here
(you can also try any other music app and see it has the same behavior since its the OS that controls this)

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 22, 2022

But if you want, you can use the Notifications plugin
and if you also want to be able to control the music from the notification, enable Interactive Notifications

its very similar to the volume osd but shows up on play/pause/next/previous track
(if you want it to show on unpause then enable unpause notifications

@bakinazik
Copy link
Author

When I create web app with edge browser, there is no such problem like this..

@bakinazik
Copy link
Author

explorer_2lshO8LfxF

@bakinazik
Copy link
Author

this is from web app on edge browser

@bakinazik
Copy link
Author

and this is from original spotify app
explorer_DqNsBy7qXb

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 22, 2022

You are right, this is really weird because it used to work.

After lots of debugging, I arrived to the conclusion its because of Electron.

Thank you for reporting this here, I will report this to Electron's team

EDIT: an issue already exist in Electron's repo about this
electron/electron#32518
i've added a comment there, hopefully they'll fix it 🙂

@JellyBrick JellyBrick added the fix-available A fix to the issue is available in a new version label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Development

No branches or pull requests

3 participants