Connection configuration provider - without changes to drivers

[oranoran]

This is a simplified PR to implement the same functionality as suggested in #3403, but with the following differences:

1. All changes were made in client.js only, so they apply to all built-in and external drivers without any changes required in them, improving extensibility and maintainability.
2. Provided connection configurations can include an expired() function, allowing configurations to expire after a while.

The expiration feature is useful, for example, for expiring Amazon RDS IAM access tokens after their lifespan of 15 minute is over, like so:

const connectionConfigProvider = () => {
    const { token, tokenExpiration } = await someCallToAwsToGetTheToken();
    return {
        host : 'your_host',
        user : 'your_database_user',
        password : token,
        database : 'myapp_test',
        expired: () => {
            return tokenExpiration <= Date.now();
        }
    };
}

I wrote the tests relying on sqlite3, hope this makes sense.
Please let me know if this direction seems right, then I'll add a documentation PR.

[kibertoad]

TypeScript definitions probably need to be updated.

[oranoran]

TypeScript definitions probably need to be updated.

I checked this, looks like the whole "connection" object is "any". Not changing anything else in the API, so didn't find anything that needs to be changed.

[oranoran]

@kibertoad Ok so the only open issue AFAIK is that I get a test failing on Oracle when Travis runs automatically. I can't reproduce this because when I try to run Oracle tests locally according to the instructions, I get an error (the npm install oracledb below runs as part of the tests, not through anything I'm doing directly, and fails):

 > DB='oracledb' mocha  --grep "Connection configuration" --exit -t 10000 test/index.js
sqlite does not support inserting default values. Set the `useNullAsDefault` flag to hide this warning. (see docs http://knexjs.org/#Builder-insert).
sqlite does not support inserting default values. Set the `useNullAsDefault` flag to hide this warning. (see docs http://knexjs.org/#Builder-insert).
sqlite does not support inserting default values. Set the `useNullAsDefault` flag to hide this warning. (see docs http://knexjs.org/#Builder-insert).
Knex: run
$ npm install oracledb --save
Cannot find module 'oracledb'
Error: Cannot find module 'oracledb'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Client_Oracledb._driver (/Users/oran/proj/knex/lib/dialects/oracledb/index.js:30:20)```

[kibertoad]

It is a flaky test, let me rerun it.

[oranoran]

TypeScript definitions probably need to be updated.

I checked this, looks like the whole "connection" object is "any". Not changing anything else in the API, so didn't find anything that needs to be changed.

Actually, looking again at index.d.ts, I see there are ConnectionConfig interfaces defined for the various databases. Should I add an expiryChecker to each one?

[kibertoad]

Would be helpful, yes.

[oranoran]

The test is still failing:

  1) Integration Tests
       oracle | oracledb
         knex.migrate
           knex.migrate.up
             should only run the next migration that has not yet run if other migrations have already run:
      AssertionError: expected [ Array(1) ] to have a length of 2 but got 1

I can't reproduce it since I'm not able to run Oracle tests, any suggestions?

P.S the TS definitions I added aren't complete, I need to add a modified connection definition too. Will add later today.

[kibertoad]

@oranoran It did pass after re-run, so as expected, flaky test, feel free to ignore.

[kibertoad]

@oranoran Could you also create a documentation PR?

[kibertoad]

@oranoran There is a conflict with types in master now.

[kibertoad]

Thanks a lot for all the effort put into this!

[oranoran]

Thanks a lot for all the effort put into this!

Thanks for maintaining this awesome lib!

[Ali-Dalal]

@oranoran Thanks for finalizing this 👍

@kibertoad when can you release it the changes?

[kibertoad]

@Ali-Dalal Released in 0.20.1