Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orderBy accepts QueryBuilder #3491

Merged
merged 3 commits into from Oct 24, 2019
Merged

orderBy accepts QueryBuilder #3491

merged 3 commits into from Oct 24, 2019

Conversation

HurSungYun
Copy link
Contributor

close #3489

@HurSungYun HurSungYun closed this Oct 19, 2019
@HurSungYun HurSungYun reopened this Oct 19, 2019
@HurSungYun
Copy link
Contributor Author

I have no idea, but integration test sometimes fails.

@kibertoad
Copy link
Collaborator

@HurSungYun Could you also update TS types and documentation?

@kibertoad kibertoad merged commit 2d04591 into knex:master Oct 24, 2019
@kibertoad
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

orderBy doesn't accept a subquery
2 participants
@HurSungYun @kibertoad