impr(oracledb): 4 fix

[maximelkin]

Idk how to test different oracledb packages
also maybe need to add some tests?

[kibertoad]

Travis needs to be updated to use latest driver, that would work as a test.

[kibertoad]

Fixes #3396

[kibertoad]

@maximelkin You can remove version from

knex/.travis.yml

Line 19 in b0c0db6

- (echo $DB | grep oracledb) && npm install oracledb@3.1.2 || true

and that should suffice.

[kibertoad]

wait, whole line shouldn't be removed :D. just the @3.1.2 part, so that latest driver version is picked up.

[kibertoad]

@maximelkin Is anything left on this PR? (you kept it asWIP)

[maximelkin]

I just want check existence of tests for lobs

[kibertoad]

Thanks!

[kibertoad]

@maximelkin Thank you for your most impressive contributions lately. Would you be interested in becoming one of the project maintainers?

[maximelkin]

@kibertoad

Would you be interested in becoming one of the project maintainers?

Sorry, not interested

[MaliaGuerrero]

Hi - there's a bug with this. If you are reading from a BLOB, this function fails:

function readStream(stream, type)

You need to set data to a Buffer:

    let data = '';
    if (type === 'buffer') {
      data = Buffer.alloc(0);
    }

I'm trying to do a PR, but I can't push....so struggling with that.

[maximelkin]

@MaliaGuerrero fork repo, push to it, then create PR from your fork to this repo

[MaliaGuerrero]

Yeah, I'm getting a 403 error. I'm attempting to work through it.

[kibertoad]

@MaliaGuerrero I think you are just trying to clone it, as I don't see you having created personal fork. Check this: https://help.github.com/en/github/getting-started-with-github/fork-a-repo

[MaliaGuerrero]

Thanks! That fixed it. I made a PR.