refactor(bluebird): remove Bluebird.bind #3477
Conversation
| @@ -475,7 +474,7 @@ class Migrator { | |||
| _waterfallBatch(batchNo, migrations, direction, trx) { | |||
| const trxOrKnex = trx || this.knex; | |||
| const { tableName, schemaName, disableTransactions } = this.config; | |||
| let current = Bluebird.bind({ failed: false, failedOn: 0 }); | |||
| let current = Promise.resolve(); | |||
There was a problem hiding this comment.
are those fields not used anywhere?
There was a problem hiding this comment.
I didn't found any usages in project
There was a problem hiding this comment.
7a6937f first revision where failedOn exists, i think it just partially implemented feature
There was a problem hiding this comment.
Fair enough, guess we can drop it.
|
Sorry, there is a merge conflict now after refactoring of a seeder. Could you resolve them? |
|
Ok, i will resolve it later |
maximelkin
force-pushed
the
bluebird_remove_bind
branch
2 times, most recently
from
b5d15cf
to
9382295
Compare
| @@ -28,7 +20,7 @@ class Seeder { | |||
| // Runs seed files for the given environment. | |||
| async run(config) { | |||
| this.config = this.setConfig(config); | |||
| const [all] = await this._seedData(); | |||
| const all = await this._listAll(); | |||
There was a problem hiding this comment.
Will types changed in https://github.com/knex/knex/pull/3438/files still be correct after this change?
There was a problem hiding this comment.
_seedData is just _listAll, but wrapping result inside promise into []
| @@ -103,22 +85,14 @@ class Seeder { | |||
| ); | |||
| } | |||
|
|
|||
| // Generates the stub template for the current seed file, returning a compiled template. | |||
There was a problem hiding this comment.
@lorefnon I assume we stopped using it after your refactoring?
There was a problem hiding this comment.
Yeah, i moved the lodash template usage to a shared utility which we can potentially use from other places as well.
|
@maximelkin Merged your other PR, that seems to have introduced a minor conflict as well. |
maximelkin
force-pushed
the
bluebird_remove_bind
branch
from
5886a20
to
5e9343e
Compare
|
@kibertoad done |
No description provided.