Fix bugs in replacement logic used when dropping columns in SQLite. #3476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lorefnon
commented
Oct 11, 2019
lorefnon
commented
- Fix regex match failure when table has not been created through knex's createTable (Closes Migrating in SQLITE: dropColumn throws error #3473)
- Handle all quote variants supported by SQLite.
- Fix incorrect handling of foreign keys & constraints
1. Fix regex match failure when table has not been created through knex's createTable (Closes #3473) 2. Handle all quote variants supported by SQLite. 3. Fix incorrect handling of foreign keys & constraints
kibertoad
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.