remove bluebird.each #3471
Merged
remove bluebird.each #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kibertoad maybe its better to merge all prs in one? |
kibertoad
reviewed
Oct 11, 2019
| @@ -128,7 +129,7 @@ Client_Oracledb.prototype.acquireRawConnection = function() { | |||
| }); | |||
| }); | |||
| }; | |||
| const fetchAsync = function(sql, bindParams, options, cb) { | |||
| const fetchAsync = promisify(function(sql, bindParams, options, cb) { | |||
There was a problem hiding this comment.
Does this function use any closure variables, or it can be moved outside to only be promisified once?
There was a problem hiding this comment.
This function use connection from outside
|
@maximelkin Keeping PRs separate makes them easier to review :) |
kibertoad
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3256