This is a patch to fix issues #1901, #2990 and #2991 #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Sep 21, 2019
package.json
Outdated
| @@ -36,6 +36,7 @@ | |||
| "liftoff": "3.1.0", | |||
| "lodash": "^4.17.15", | |||
| "mkdirp": "^0.5.1", | |||
| "oracledb": "^4.0.1", | |||
There was a problem hiding this comment.
It would be preferable to avoid adding this, but instead move tests to integration test suite and skipping it for non-oracle dbs.
There was a problem hiding this comment.
Where in the integrations folder should I place the tests?
There was a problem hiding this comment.
I'd say that https://github.com/tgriesser/knex/tree/master/test/integration/builder, probablyadditional, since I assume this is not a select per se?
kibertoad
approved these changes
Sep 21, 2019
|
Did we have some wiki or cookbook for knex? That kind of entry would be great for documentation. Also great work, this has been very wanted feature 👍 |
|
I will create a cookbook on how to call an oracle stored procedure and get the results :D |
|
Simple example added to the recipe. |
|
Released in 0.19.5 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Oracle stored procedures and get the error 'expecting an array or an iterable object but got [object Null]' . This bugfix is kind of important as we convert old MuleSoft flows to Node endpoints.
Let me know if you need any more information or documentation.