Update tarn.js #3345
Update tarn.js #3345
Conversation
|
afterCreate is implemented in knex side and looks like it is passed to pool paameters by accident. |
| @@ -90,7 +90,7 @@ describe('Seeder._waterfallBatch', function() { | |||
| it('should throw an error with correct file name', (done) => { | |||
| seeder._waterfallBatch(['1-first.js', '2-second.js']).catch((error) => { | |||
| expect(error.message).to.match( | |||
| /^Error while executing "(\/\w+)+\/1-first\.js" seed: throwing in first file$/ | |||
| /^Error while executing .*1-first.js" seed: throwing in first file$/ | |||
There was a problem hiding this comment.
Original assertion was failing on Windows
| }; | ||
| // afterCreate is an internal knex param, tarn.js does not support it | ||
| if (tarnPoolConfig.afterCreate) { | ||
| delete tarnPoolConfig.afterCreate; |
There was a problem hiding this comment.
You will have the same issue with beforeDestroy I think.
There was a problem hiding this comment.
beforeDestroy is deprecated and is not really useful hook anyways (it has been deprecated already for a long time). I think we can drop it already.
There was a problem hiding this comment.
Sure the PR should simply delete it from the code so there is no way it is passed by error then :)
There was a problem hiding this comment.
Removed beforeDestroy from typings and implementation, and mentioned in migration guide that it's no longer supported. Users should still update their code not to pass it, though, as silently ignoring configuration options is confusing.
There was a problem hiding this comment.
When people start complaining that their hacky code (*) doesn't work without it we can tell them to use pool's event handlers instead.
*) code relaying to that hook cannot work in a robust manner unless it is counting more or less how many connections were discarded from pool... so far all the people who has been using it and with whom I've been talking to have made invalid assumptions when that is called and have tried to do some DB disconnected kind recognitions and knex re-inits there.
There was a problem hiding this comment.
Yeah, migration guide already mentions pool event handlers.
* Update tarn.js * Remove beforeDestroy
No description provided.