Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mssql import not being ignored due to change in browser field in package.json #3336

Merged
merged 1 commit into from Jul 7, 2019
Merged

Fix mssql import not being ignored due to change in browser field in package.json #3336

merged 1 commit into from Jul 7, 2019

Conversation

lorefnon
Copy link
Collaborator

@lorefnon lorefnon commented Jul 7, 2019

Fixes: #5877

@lorefnon
Copy link
Collaborator Author

lorefnon commented Jul 7, 2019

I am assuming that this was result of a quick find/replace in editor.
If there was a reason for this change I can close this PR and check further.

@kibertoad kibertoad merged commit 0e59624 into knex:master Jul 7, 2019
@kibertoad
Copy link
Collaborator

Nope, definitely careless mass replace after removal of babel. Thank you!

felixmosh pushed a commit to felixmosh/knex that referenced this pull request Jul 13, 2019
@lorefnon @felixmosh
Fix mssql import not being ignored due to change in browser field in …
2612c97 
…package.json (knex#3336)

Fixes: https://github.com/knex/documentation/issues/212
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack is throwing an error during build
2 participants
@lorefnon @kibertoad