feat: Run specific seed file (closes #801) #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Jul 6, 2019
test/integration/seed/index.js
Outdated
| return knex.seed | ||
| .run({ directory: 'test/integration/seed/test' }) | ||
| .then(([data]) => { | ||
| expect(path.basename(data[0])).to.equal('seed1.js'); | ||
| expect(path.basename(data[1])).to.equal('seed2.js'); | ||
| }); | ||
| }); | ||
|
|
||
| it('should run specific seed file in the configured seed directory', () => { |
There was a problem hiding this comment.
async-await is preferable for new tests
|
Could you please also create documentation pr in knex documentation repo? |
I've added the additional "sections" in the documentation, but when run dev / build and serving the docs, I don't see the additions even though I do see the additions in the source code of the html. Any help? |
|
Ok, managed to fix the issue, apparently there is Added: knex/documentation#213 |
kibertoad
approved these changes
Jul 7, 2019
|
Thank you! |
felixmosh
added a commit
to felixmosh/knex
that referenced
this pull request
Jul 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This features allows to run a specific seed file.
It adds an additional cli property
--specific=filename.jswhich points to some seed file in the seed directory.usage:
npx knex seed:run --specific=seed-filename.js