Fix remove duplicate transaction promise #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add test case for the bug it fixes? |
|
As i said in the issue - your tests are already sufficient. You can see it in tests logs. Look: logs for PR that introduced the problem (there are 260 If you want tests to show rejections more clearly you should force tests to exit with non-zero status on unhandled rejections. How to do it i wrote in the issue. But you need to eliminate other unhandled rejections (there are around ten of them) before you do so. |
kibertoad
approved these changes
Jun 30, 2019
|
Thanks! I'll release a fixed version shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes second issue from #3309.