CLI/add stub option #3316
Merged
CLI/add stub option #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**usage** -`--stub <name>` looks for stub file by name in `config.migrations.directory` - `--stub </file/path>` looks for stub file by path relative to `knexfile.*`
- add utilities for testing the --stub option - add success and failure tests for --stub option
kibertoad
reviewed
Jun 30, 2019
kibertoad
reviewed
Jun 30, 2019
kibertoad
reviewed
Jun 30, 2019
kibertoad
reviewed
Jun 30, 2019
kibertoad
reviewed
Jun 30, 2019
- moving the 2 utils getMigrationsExtensions, getStubPath had dependencies - the depended utils had to be moved over as well and their libs imported - utils moved: exit, success, resolveEnvironmentConfig, checkLocalModule
- bumped cli-testlab to 1.7.0 - now using new fileHelper glob reader
- add setupFileHelper test util
the-vampiire
commented
Jul 1, 2019
|
|
||
| function getStubPath(env, opts) { | ||
| const config = resolveEnvironmentConfig(opts, env.configuration); | ||
| const stubDirectory = config.migrations && config.migrations.directory; |
There was a problem hiding this comment.
this could be moved down. doesnt need to be assigned unless func reaches line 133
kibertoad
approved these changes
Jul 4, 2019
|
Thanks! |
|
Released in 0.18.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3219
adds
--stuboption tomigration:makeCLI commandusage
--stub <name>looks for stub file by name inconfig.migrations.directory--stub </file/path>looks for stub file by path relative toknexfile.*