Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Fix empty --version output #3312

Merged
merged 2 commits into from Jun 30, 2019
Merged

CLI: Fix empty --version output #3312

merged 2 commits into from Jun 30, 2019

Conversation

Saka7
Copy link
Contributor

@Saka7 Saka7 commented Jun 27, 2019

Currently, --version/-V output looks broken (empty output):

knex --version

Knex CLI version: 
Local Knex version:

#3311

@Saka7 Saka7 mentioned this pull request Jun 27, 2019
Closed
@kibertoad
Copy link
Collaborator

Thank you! Could you please add test for this? Look at https://github.com/tgriesser/knex/tree/master/test/cli for inspiration.

@kibertoad
Copy link
Collaborator

@Saka7 Please let me know if you'll need any help with writing a test!

@Saka7
Copy link
Contributor Author

Saka7 commented Jun 30, 2019

@kibertoad I've added a test for cli version, please check

@kibertoad kibertoad merged commit 0a85331 into knex:master Jun 30, 2019
@kibertoad
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Saka7 @kibertoad