Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use extension from knexfile filename for generating migrations unless overriden #3282

Merged
merged 1 commit into from Jun 14, 2019
Merged

Use extension from knexfile filename for generating migrations unless overriden #3282

merged 1 commit into from Jun 14, 2019

Conversation

kibertoad
Copy link
Collaborator

@kibertoad kibertoad commented Jun 13, 2019 •
edited

fixes #3003

@kibertoad kibertoad mentioned this pull request Jun 13, 2019
Closed
@kibertoad kibertoad changed the title Use extension from knexfile for generating migrations unless overriden Use extension from knexfile path for generating migrations unless overriden Jun 13, 2019
@kibertoad kibertoad changed the title Use extension from knexfile path for generating migrations unless overriden Use extension from knexfile filenamefor generating migrations unless overriden Jun 13, 2019
@kibertoad kibertoad changed the title Use extension from knexfile filenamefor generating migrations unless overriden Use extension from knexfile filename for generating migrations unless overriden Jun 13, 2019
@dgadelha
Copy link

It works for me, is it possible to release this?

@kibertoad
Copy link
Collaborator Author

@dgadelha 0.18.0 is not yet ready, would next-1 work for you? Also master is not transpiled anymore, so you can directly depend on branches and commits.

@dgadelha
Copy link

It would, can we depend a commit directly from npm? Thought you had to publish it there.

@kibertoad
Copy link
Collaborator Author

You definitely can! https://medium.com/@jonchurch/use-github-branch-as-dependency-in-package-json-5eb609c81f1a

@kibertoad kibertoad merged commit 04b12f2 into master Jun 14, 2019
@kibertoad kibertoad deleted the 3003-resolve-extension-from-knexfile branch June 14, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate:make fails with TypeScript
2 participants
@kibertoad @dgadelha