Fix error message bubbling up on seed error

[risseraka]

Problem: When the nth seed throws an error, all subsequent seeds add an error message on top of original message which makes it less clear which seed the error originated from.

Solution: Nest promises and catch error inside the nested seed promise.

Before:

Error: Error while executing ".../knex/seeds/9-titres-activites.js" seed: Error while executing ".../knex/seeds/8-metas-activites.js" seed: Error while e
xecuting ".../knex/seeds/7-titres.js" seed: insert into "titres_points" ("contour", "coordonnees", "description", "groupe", "id", "nom", "point"
    at Object.current.then.then.catch.originalError (.../node_modules/knex/lib/seed/Seeder.js:166:23)
Error: Error while executing ".../knex/seeds/8-metas-activites.js" seed: Error while executing ".../knex/seeds/7-titres.js" seed: insert into "titres_poi
nts" ("contour", "coordonnees", "description", "groupe", "id", "nom", "point"
    at Object.current.then.then.catch.originalError (.../node_modules/knex/lib/seed/Seeder.js:166:23)
Error: Error while executing ".../knex/seeds/7-titres.js" seed: insert into "titres_points" ("contour", "coordonnees", "description", "groupe", "id", "nom", "point" [...]
    at Object.current.then.then.catch.originalError (.../node_modules/knex/lib/seed/Seeder.js:166:23)

After:

Error: Error while executing ".../knex/seeds/7-titres.js" seed: insert into "titres_points" ("contour", "coordonnees", "description", "groupe", "id", "nom", "point" [...]
    at Object.current.then.then.catch.originalError (.../node_modules/knex/lib/seed/Seeder.js:166:23)

LMKWYT,
Cheers.

[kibertoad]

Thanks! Could you add unit test for that?

[risseraka]

Hi Igor,

Sure, this behavior is not trivial, but I'll try to come up with something.

[risseraka]

Alright, I've added a straightforward test, which fails on master but passes on this branch.

Error output on master:

Error while executing "[...]/knex/test/unit/seed/test/2-second.js" seed: Error while executing "[...]/knex/test/unit/seed/test/1-first.js" seed: throwing in first file

Error output on this branch:

Error while executing "[...]/knex/test/unit/seed/test/1-first.js" seed: throwing in first file

PS: tests seem to be quite broken on the past few pull requests, is it something to be worried about?

[kibertoad]

@risseraka There are some flaky Oracle tests, these are to be ignored, anything else - I'd need to check that out :)

[kibertoad]

Thanks a lot for your contribution!

[risseraka]

You're very welcome, thanks for your and every contributor's hard work.

(Impressive speed by the way. 😅)

[kibertoad]

My pleasure!
How urgently do you need this change released? I wasn't planning another release before 0.18 unless something serious popped up, but we can figure something out if it's something you need urgently.

[risseraka]

@kibertoad No worries, there's absolutely no urgency, it was just a bit annoying to look at logs on errors, so it's mostly cosmetic, take your time to release whenever you see fit.

[kibertoad]

Released in 0.18.0-next1

[risseraka]

Thanks for the heads up.
Hurray for @kibertoad!