Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task directives do not update unless the task failed #161

Open
bryce-turner opened this issue Sep 19, 2023 · 0 comments
Open

Task directives do not update unless the task failed #161

bryce-turner opened this issue Sep 19, 2023 · 0 comments

Comments

@bryce-turner
Copy link
Member

This was originally mentioned in #117, but the issue proposed adding reset to the task identity.

Originally from #117 :

Reset directive

This one is more difficult. There is a problem currently with not being able to update task directives unless the task identity has changed. Maybe a better fix here would be to change the workflow mash function so that it always updates task directives, but only resets the task if the identity has changed.

Alternatively, we could just add the reset directive to the identity calculation. The big downside here is that if you have a workflow already run, adding reset directives to a task will reset it.

This mostly focused on the reset directive since we may want tasks to reset, but we don't necessarily want to update the task identity and therefore cause more tasks to restart than needed.

Another example is say we want to add an input or output to a task for better support with the slurm_singularity backend. Right now we would have to set the task to failed or otherwise force it to be re-rendered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant