Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential security vulnerabilities in the python dependencies #278

Closed
1 of 2 tasks
gkaracha opened this issue Oct 22, 2021 · 5 comments
Closed
1 of 2 tasks

Potential security vulnerabilities in the python dependencies #278

gkaracha opened this issue Oct 22, 2021 · 5 comments
Assignees

Comments

@gkaracha
Copy link
Contributor

gkaracha commented Oct 22, 2021

Since #272 was merged I've been seeing the following Dependabot warning:

We found potential security vulnerabilities in your dependencies.

The warning refers to two python dependencies in our poetry.lock:

We should probably fix that.

@dorranh
Copy link
Contributor

dorranh commented Nov 1, 2021

The first point is actually a bit blocked by pytezos which pins an older version of fastecdsa. We can hack around that need be, but the cleaner solution is to upgrade it upstream. I created an issue for this here: baking-bad/pytezos#261

@dorranh
Copy link
Contributor

dorranh commented Nov 1, 2021

The pywin32 one is an issue with both our version of docker-py and that used by pytezos. However, we can't bump our docker-py version to the latest release (5.0.3) until pytezos upgrades since pytezos places an upper bound of <5.0.0.

@dorranh
Copy link
Contributor

dorranh commented Dec 14, 2021

Note: the pywin32 vulnerability is blocked on docker/docker-py#2925.

@dorranh
Copy link
Contributor

dorranh commented Dec 31, 2021

After reviewing the pywin32 vulnerability a bit more, it seems that this should only affect people running checker's python applications directly on Windows (i.e. on the Windows host itself and not from within a Docker container running on Windows). Since very few of the tools in our stack are supported on Windows, I'm going to go ahead and dismiss that alert. Please feel free to re-open though.

@dorranh dorranh closed this as completed Dec 31, 2021
@gkaracha
Copy link
Contributor Author

gkaracha commented Jan 3, 2022

Sounds good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants