Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build to go 1.20 #921

Closed
codefromthecrypt opened this issue Dec 14, 2022 · 1 comment · Fixed by #1096
Closed

update build to go 1.20 #921

codefromthecrypt opened this issue Dec 14, 2022 · 1 comment · Fixed by #1096
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@codefromthecrypt
Copy link
Contributor

We should prepare for Go 1.20, as this is the version we cut 1.0 with early next year.

-          - "1.19"  # Current Go version
-          - "1.17"  # Floor Go version of wazero (current - 2)
+          - "1.20rc1"  # Next Go version
+          - "1.17"      # Floor Go version of wazero (current - 2)

There are some issues to solve with 1.20rc1
@codefromthecrypt codefromthecrypt added enhancement New feature or request help wanted Extra attention is needed labels Dec 14, 2022
@codefromthecrypt
Copy link
Contributor Author

I see no progress on the lint side of things

codefromthecrypt pushed a commit that referenced this issue Feb 3, 2023
Raises floor Go version from 1.17 to 1.18
ecca653 
This moves our floor version to the same we'll release 1.0 with: 1.18.
This is congruent with our version policy which is current-2.

Fixes #921

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt codefromthecrypt mentioned this issue Feb 3, 2023
Merged
codefromthecrypt pushed a commit that referenced this issue Feb 6, 2023
Raises floor Go version from 1.17 to 1.18
09fd21e 
This moves our floor version to the same we'll release 1.0 with: 1.18.
This is congruent with our version policy which is current-2.

Fixes #921

Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt pushed a commit that referenced this issue Feb 6, 2023
ci: supports building with Go 1.20 and raises floor version to 1.18
4f0f289 
This moves our floor version to the same we'll release 1.0 with: 1.18.
This is congruent with our version policy which is current-2.

Fixes #921

Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt added a commit that referenced this issue Feb 6, 2023
@codefromthecrypt
ci: supports building with Go 1.20 and raises floor version to 1.18 (#…
8918d73 
…1096)

This moves our floor version to the same we'll release 1.0 with: 1.18.
This is congruent with our version policy which is current-2.

Fixes #921

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: supports building with Go 1.20 and raises floor version to 1.18 tetratelabs/wazero
1 participant
@codefromthecrypt