Change default scope to DeclScope #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `README` says the default scope is `declarations` but the code currently sets it to `toplevel`. So one or the other needs to be adjusted so they are in-sync. We have hit a bunch of false positives with `toplevel` and so would prefer to keep the default at `declarations`. Especially since it's painful to change just that setting as it requires a config file since it's not possible to pass in a dict/map of custom settings as a CLI arg: #17
Actually you can But still thanks for your PR. The code should be in sync with the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
READMEsays the default scope isdeclarationsbut the code currently sets it totoplevel.So one or the other needs to be adjusted so they are in-sync.
We have hit a bunch of false positives with
topleveland so would prefer to keep the default atdeclarations.Especially since it's painful to change just that setting as it requires a config file since it's not possible to pass in a dict/map of custom settings as a CLI arg:
#17