Test Smell: it is not a good practice to write a return statement in the test case

[TestSmell]

Hi!
I notice that you write a test case with a return statement.
For example,

It is not a good idea to write the return statement in your test case based on the definition of the test case.
So I would like to know if is it really a useful test case? And no assertion is in this test case.
Maybe I think you should remove this test case from your test code. Thanks.

[juherr]

Right. It may be one of the first tests when the current best practices didn't exist.

The cannot be removed because I think there is not yet a warning against this practice.

You can propose a pull request that adds a warning message.
You can add a "for removal" tag to related tests.

[rajasu8]

@juherr can I take this?

[juherr]

@rajasu8 sure. Go ahead 👍