fix(document): reduce impact of React@17 workaround #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84c673a:
|
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 1837 1843 +6
Branches 678 683 +5
=========================================
+ Hits 1837 1843 +6
Continue to review full report at Codecov.
|
ph-fritsche
changed the title
|
🎉 This PR is included in version 14.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Apply workaround only if the element is controlled by React17.
Do not reapply cursor position if selection has been changed by user code.
Why:
Closes #971
The rollback to previous value before applying a state update in test environment is specific to React@17.
How:
Check if
window.REACT_VERSION === 17and if the__reactproperties exist on the element, before applying the workaround.Checklist: