Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(document): use setters/methods on element as default #987

Merged
merged 1 commit into from Jul 14, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

We circumvent the setters/methods on element objects when we change "UI" selection/value.
Do not directly apply prototype setters/methods for programmatic calls.

Why:

Closes #986

How:

Set default for applyNative to false.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3bc4db3:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
brave-silence-opvvtp Issue #986

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #987 (3bc4db3) into main (29bdf14) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #987   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           86        86           
  Lines         1837      1836    -1     
  Branches       679       678    -1     
=========================================
- Hits          1837      1836    -1     
Impacted Files Coverage Δ
src/document/selection.ts 100.00% <ø> (ø)
src/document/interceptor.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bdf14...3bc4db3. Read the comment docs.

@ph-fritsche ph-fritsche merged commit c40e614 into main Jul 14, 2022
@ph-fritsche ph-fritsche deleted the iss-986 branch July 14, 2022 11:35
@github-actions
Copy link

🎉 This PR is included in version 14.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest.spyOn() does not work with type() in some cases
1 participant