Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset UI selection after programmatic value change #915

Merged
merged 2 commits into from Apr 11, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Reset the UI selection only after updating a value programmatically.

Why:

Closes #912

How:

#889 replaced just clearing the UISelection with updating it to maintain it on inputs without selectionRange.
setUISelection sanitizes the focusOffset so that it needs to be applied after the changes to value.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f3c6a3:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
frosty-butterfly-73stzl Issue #912
awesome-thompson-674uvr Issue #912

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #915 (3f3c6a3) into main (f5049c4) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         1782      1783    +1     
  Branches       641       640    -1     
=========================================
+ Hits          1782      1783    +1     
Impacted Files Coverage Δ
src/document/interceptor.ts 100.00% <100.00%> (ø)
src/document/value.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5049c4...3f3c6a3. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 8bc3310 into main Apr 11, 2022
@ph-fritsche ph-fritsche deleted the fix-912 branch April 11, 2022 07:58
@github-actions
Copy link

🎉 This PR is included in version 14.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userEvent.type - issue when using {Alt>}{Enter}{/Alt}
1 participant