Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track calls to HTMLInputElement.select() #898

Merged
merged 1 commit into from Apr 1, 2022
Merged

fix: track calls to HTMLInputElement.select() #898

merged 1 commit into from Apr 1, 2022

Conversation

ph-fritsche
Copy link
Member

What:

Support setting the UI selection per HTMLInputElement.select().

Why:

Closes #897

How:

Add an interceptor on the method and change UISelection accordingly.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5bc1701:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration
testing-lib-user-event-897 Issue #897

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #898 (5bc1701) into main (f2e8f8e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         1774      1778    +4     
  Branches       657       657           
=========================================
+ Hits          1774      1778    +4     
Impacted Files Coverage Δ
src/document/selection.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2e8f8e...5bc1701. Read the comment docs.

@ph-fritsche
Copy link
Member Author

@ph-fritsche ph-fritsche merged commit 6d36828 into main Apr 1, 2022
@ph-fritsche ph-fritsche deleted the fix-897 branch April 1, 2022 07:04
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

🎉 This PR is included in version 14.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection issue with .type()
1 participant