Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointer): support nested select #888

Merged
merged 2 commits into from Mar 31, 2022
Merged

fix(pointer): support nested select #888

merged 2 commits into from Mar 31, 2022

Conversation

robcaldecott
Copy link
Contributor

What:
This PR fixes #887

Why:
A label with a nested select would cause a crash when using selectOptions.

How:

  • Adding select to the closest selector to match a previous fix for input typing.
  • Including a specific test for select to prove the fix works.

Checklist:

  • [N/A] Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 30, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05c11aa:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #888 (05c11aa) into main (a7f9906) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #888   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           84        84           
  Lines         1758      1758           
  Branches       639       639           
=========================================
  Hits          1758      1758           
Impacted Files Coverage Δ
src/event/behavior/click.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f9906...05c11aa. Read the comment docs.

@ph-fritsche ph-fritsche merged commit e23e559 into testing-library:main Mar 31, 2022
@github-actions
Copy link

🎉 This PR is included in version 14.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded error when testing a <select>
2 participants