Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Jest 27 #693

Merged
merged 2 commits into from Jul 17, 2021
Merged

chore: upgrade to Jest 27 #693

merged 2 commits into from Jul 17, 2021

Conversation

nickmccurdy
Copy link
Member

What: Upgrade to Jest 27

Why: Ensuring compatibility with breaking changes in Jest 27

How: Upgrading packages

Checklist:

  • Documentation (N/A)
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 33aff37:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #693 (33aff37) into master (4029441) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #693   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          934       934           
  Branches       367       368    +1     
=========================================
  Hits           934       934           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4029441...33aff37. Read the comment docs.

Comment on lines +235 to 236
// eslint-disable-next-line testing-library/no-await-sync-events
await userEvent.type(element, text, {delay})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plugin not picking up the overload anymore ? 😞

This might be just another reason for us to always return a Promise on userEvent.type in the next major.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it.

I've opened testing-library/eslint-plugin-testing-library#403 so we can discuss it there. Would you still want to merge this in the meantime or would you rather wait for that to be fixed?

@github-actions
Copy link

🎉 This PR is included in version 13.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants