Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): apply changeInit correctly #670

Merged
merged 3 commits into from Apr 29, 2021
Merged

fix(upload): apply changeInit correctly #670

merged 3 commits into from Apr 29, 2021

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Apr 29, 2021

What:

Closes #667

Why:

init argument was deconstructured incorrectly.
The typing of init.changeInit was incorrect.

Checklist:

  • [N/A] Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7495b8a:

Sandbox Source
userEvent-PR-template Configuration
user-event upload changeInit example Issue #667

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #670 (7495b8a) into master (557caaf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #670   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          930       930           
  Branches       366       366           
=========================================
  Hits           930       930           
Impacted Files Coverage Δ
src/upload.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557caaf...7495b8a. Read the comment docs.

@ph-fritsche ph-fritsche merged commit de09b1b into master Apr 29, 2021
@ph-fritsche ph-fritsche deleted the fix-667 branch April 29, 2021 10:32
@github-actions
Copy link

🎉 This PR is included in version 13.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userEvent.upload changeInit option does not update the change event
1 participant