Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): add link to docs in key descriptor error #666

Merged
merged 1 commit into from Apr 28, 2021
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Closes #633

Why:

People updating userEvent get confused by the error messages about expected key descriptors or unexpected brackets.

How:

Add a link to the section of the README explaining how userEvent parses the text argument.

Checklist:

  • [N/A] Documentation
  • [N/A] Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc681f3:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #666 (cc681f3) into master (1560b29) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #666   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          930       930           
  Branches       366       366           
=========================================
  Hits           930       930           
Impacted Files Coverage Δ
src/keyboard/getNextKeyDef.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1560b29...cc681f3. Read the comment docs.

@ph-fritsche ph-fritsche merged commit ebc90d8 into master Apr 28, 2021
@ph-fritsche ph-fritsche deleted the fix-633 branch April 28, 2021 19:37
@github-actions
Copy link

🎉 This PR is included in version 13.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

userEvent.type with empty string causes a warning about an unhandled promise rejection
1 participant