Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: continue testing on Node 15 #663

Merged
merged 2 commits into from May 8, 2021
Merged

Conversation

nickmccurdy
Copy link
Member

It's still supported until June 1

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb28a10:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #663 (cb28a10) into master (03f38b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          932       932           
  Branches       367       363    -4     
=========================================
  Hits           932       932           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f38b9...cb28a10. Read the comment docs.

@nickmccurdy
Copy link
Member Author

I would merge, but I'm not sure how we'd want to update the branch protection rules

@ph-fritsche
Copy link
Member

I think running it without requiring it is fine. But we could as well drop it or add the check requirement.
It's just about a month and this repo doesn't do anything that can be expected to work in one node version but not the other.
It's more or less just a smoke test for our config and dependencies and I don't expect any of them to support node16 and node14 but break in node15.

@nickmccurdy
Copy link
Member Author

nickmccurdy commented May 6, 2021

Personally I'd still rather have that smoke test even though it's unlikely to fail, because Node 15 is still supported for now.

@ph-fritsche ph-fritsche merged commit 224b207 into master May 8, 2021
@ph-fritsche ph-fritsche deleted the nickmccurdy-patch-1 branch May 8, 2021 10:34
@github-actions
Copy link

🎉 This PR is included in version 13.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants