Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): suppress invalid input on <input type="number"> #628

Merged
merged 1 commit into from Mar 25, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Ignore otherwise valid characters that do not trigger input events and change the displayed value at that position.

Why:

Closes #606

How:

Test the resulting new value against known invalid patterns.

Checklist:

  • N/A Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c08378b:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #628 (c08378b) into master (51bffe9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #628   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines          885       891    +6     
  Branches       347       351    +4     
=========================================
+ Hits           885       891    +6     
Impacted Files Coverage Δ
src/keyboard/plugins/character.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bffe9...c08378b. Read the comment docs.

@ph-fritsche ph-fritsche merged commit f633a52 into master Mar 25, 2021
@ph-fritsche ph-fritsche deleted the fix-606 branch March 25, 2021 19:24
@github-actions
Copy link

🎉 This PR is included in version 13.0.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: input event on <input type="number">
1 participant