Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwrite selection with same input #623

Merged
merged 7 commits into from Mar 25, 2021
Merged

fix: overwrite selection with same input #623

merged 7 commits into from Mar 25, 2021

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Mar 24, 2021

What:

Refactor calculateNewValue.
If input event should be fired is determined in the plugins now, moving handling of edge cases out of fireInputEvent(IfNeeded).

Why:

Closes #583

How:

See #607 (comment)

Checklist:

  • N/A Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #623 (6c8e3d6) into master (5c40248) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #623   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        48    +2     
  Lines          884       877    -7     
  Branches       330       345   +15     
=========================================
- Hits           884       877    -7     
Impacted Files Coverage Δ
src/keyboard/plugins/character.ts 100.00% <100.00%> (ø)
src/keyboard/plugins/control.ts 100.00% <100.00%> (ø)
src/keyboard/plugins/functional.ts 100.00% <100.00%> (ø)
src/keyboard/shared/carryValue.ts 100.00% <100.00%> (ø)
src/keyboard/shared/fireInputEvent.ts 100.00% <100.00%> (ø)
src/paste.ts 100.00% <100.00%> (ø)
src/type/typeImplementation.ts 100.00% <100.00%> (ø)
src/utils/edit/calculateNewValue.ts 100.00% <100.00%> (ø)
src/utils/edit/cursorPosition.ts 100.00% <100.00%> (ø)
src/utils/edit/isContentEditable.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c40248...6c8e3d6. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 394d425 into master Mar 25, 2021
@ph-fritsche ph-fritsche deleted the fix-583 branch March 25, 2021 09:26
@github-actions
Copy link

🎉 This PR is included in version 13.0.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing fails if input matches selection
1 participant