Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): inputType for Enter on contenteditable #614

Merged
merged 3 commits into from Mar 23, 2021
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Dispatch input event with inputType: 'insertParagraph' on contenteditable if shiftKey: false.

Fix an exception if getSelectionRange is called on contenteditable and Selection.rangeCount === 0

Why:

Closes #605

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #614 (05a49d5) into master (4c3d3cf) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          880       884    +4     
  Branches       330       333    +3     
=========================================
+ Hits           880       884    +4     
Impacted Files Coverage Δ
src/keyboard/plugins/character.ts 100.00% <100.00%> (ø)
src/utils/edit/getSelectionRange.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3d3cf...05a49d5. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 2b0632a into master Mar 23, 2021
@ph-fritsche ph-fritsche deleted the fix-605 branch March 23, 2021 13:42
@github-actions
Copy link

🎉 This PR is included in version 13.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: wrong inputType on contenteditable
1 participant