Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paste): correct the paste event type (#512) #611

Merged
merged 1 commit into from Mar 23, 2021
Merged

fix(paste): correct the paste event type (#512) #611

merged 1 commit into from Mar 23, 2021

Conversation

fergusmcdonald
Copy link
Contributor

What: Fix the event init type of paste by changing from MouseEventInit to ClipboardEventInit. This aligns with the type definition of fireEvent for pasting: https://github.com/testing-library/dom-testing-library/blob/master/src/event-map.js#L11-L14

Why: Types should be correct.

How: N/A

Checklist:

  • Documentation
  • Tests
  • Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #611 (6d2d69b) into master (0fe1fec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #611   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          880       880           
  Branches       331       331           
=========================================
  Hits           880       880           
Impacted Files Coverage Δ
src/paste.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe1fec...6d2d69b. Read the comment docs.

@ph-fritsche ph-fritsche linked an issue Mar 23, 2021 that may be closed by this pull request
@ph-fritsche ph-fritsche merged commit d612aa4 into testing-library:master Mar 23, 2021
@ph-fritsche
Copy link
Member

ph-fritsche commented Mar 23, 2021

@all-contributors add @fergusmcdonald code

@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @fergusmcdonald! 🎉

@github-actions
Copy link

🎉 This PR is included in version 13.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fergusmcdonald fergusmcdonald deleted the pr/fix-512 branch March 23, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paste eventInit Type should be ClipboardEventInit
2 participants