Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: right click triggers contextmenu #601

Merged
merged 1 commit into from Mar 19, 2021
Merged

fix: right click triggers contextmenu #601

merged 1 commit into from Mar 19, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Dispatch contextmenu instead of click for right button clicks.

Why:

Closes #445

How:

Check button === 2 before calling fireEvent.click/fireEvent.contextmenu

Checklist:

  • N/A Documentation
  • Tests
  • N/A Typings
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #601 (149a699) into master (2ef89dd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #601   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          871       875    +4     
  Branches       329       330    +1     
=========================================
+ Hits           871       875    +4     
Impacted Files Coverage Δ
src/click.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef89dd...149a699. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 16847e1 into master Mar 19, 2021
@ph-fritsche ph-fritsche deleted the fix-445 branch March 19, 2021 17:49
@github-actions
Copy link

🎉 This PR is included in version 13.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contextMenu not callable
1 participant