Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript error in click function when upgrading to v13.0.3 #598

Closed
sstauross opened this issue Mar 19, 2021 · 4 comments · Fixed by #599
Closed

Typescript error in click function when upgrading to v13.0.3 #598

sstauross opened this issue Mar 19, 2021 · 4 comments · Fixed by #599
Labels
bug Something isn't working released

Comments

@sstauross
Copy link

  • @testing-library/user-event version: 13.0.3
  • Testing Framework and version: jest@26.6.0
  • DOM Environment:
  • "@testing-library/jest-dom": "^5.11.9",
    "@testing-library/react": "^11.2.5",

What you did: Upgrading to v13.0.3 the types exported seem to have the init property of the click function as mandatory while in click.d.ts in the repo it seems to be optional.

What happened: Typescript error.

image
image
@ph-fritsche ph-fritsche added the bug Something isn't working label Mar 19, 2021
@ph-fritsche ph-fritsche mentioned this issue Mar 19, 2021
Merged
2 tasks
@ph-fritsche
Copy link
Member

@sstauross Thanks a lot for the report.

Could you have a look at #599 ?

@ph-fritsche
Copy link
Member

@all-contributors add @sstauross bug

@allcontributors allcontributors bot mentioned this issue Mar 19, 2021
Merged
@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @sstauross! 🎉

@github-actions
Copy link

🎉 This issue has been resolved in version 13.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: convert exported modules to typescript testing-library/user-event
2 participants
@sstauross @ph-fritsche