Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(upload): apply accept attribute" #563

Merged
merged 1 commit into from Feb 23, 2021
Merged

Conversation

ph-fritsche
Copy link
Member

Reverts #558

Filtering the files for the the input event causes problems for those testing their own filters.
#558 (comment)

We can not consider these changes a fix.

We should discuss them as a new feature here: #562

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #563 (9022938) into master (985d1a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #563   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          710       699   -11     
  Branches       223       221    -2     
=========================================
- Hits           710       699   -11     
Impacted Files Coverage Δ
src/upload.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985d1a7...749dfd2. Read the comment docs.

@ph-fritsche ph-fritsche changed the title revert: "fix: do not allow to upload files with invalid formats" revert: "fix(upload): apply accept attribute" Feb 23, 2021
@ph-fritsche ph-fritsche merged commit 7a5c51e into master Feb 23, 2021
@ph-fritsche ph-fritsche deleted the revert-558-master branch February 23, 2021 12:56
@github-actions
Copy link

🎉 This PR is included in version 12.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant