fix: check element type in different environments #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 684 692 +8
Branches 214 216 +2
=========================================
+ Hits 684 692 +8
Continue to review full report at Codecov.
|
4 tasks
|
I think I'd prefer to merge the one in DOM, and then just bump the peerDep here, but either way this looks fine to me 👍 thanks! |
2 tasks
|
@kentcdodds testing-library/dom-testing-library#885 is closed so I guess we should merge this one. |
|
Sounds good to me 👍 |
|
🎉 This PR is included in version 12.6.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper to verify the element type in different environments.
What:
Add a helper to utils.
This can be removed from this library and replaced by a shared helper in
@testing-library/domonce it is bumped to a version that includes testing-library/dom-testing-library#885.Why:
See #550
How:
The helper tries to find the element constructor on the window.
As the window is neither required to be associated with the observed document nor is it required to provide any element constructors, the helper provides a fallback for other environments than Jest+JSDOM.
Checklist: