Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
These changes fix bugs on selectOptions.
Why:
selectOptions
failed to trigger correct events on options withrole
attribute. - seeselectOptions
fails on options withrole
attribute #542selectOptions
missed pointer events that happen when selecting an option of regular<select>
.selectOptions
made the false assumption the browser would changearia-selected
attributes when clicking an element withrole="option"
.See https://codesandbox.io/s/user-event-changle-handler-with-role-forked-d5ubs?file=/src/LoggingSelects.js for tracking events that actually happen in the browser.
How:
listbox
instead ofrole
attribute of theoption
.Checklist: