New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specialChars): Create and expose specialChars
map
#510
feat(specialChars): Create and expose specialChars
map
#510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 674 675 +1
Branches 211 211
=========================================
+ Hits 674 675 +1
Continue to review full report at Codecov.
|
Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me seems cool, thanks @vasilii-kovalev 😄 👍
* Add {arrowdown} and {arrowup} to `specialChars` map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me is still ok, let's wait the opinion of someone else, thank you for your works 😄
@kentcdodds, hello! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm ok with this. I personally wouldn't use it, but I can understand why others might 👍
I'm good with this, but I'm going to let someone else merge it :) |
@all-contributors please add @vasilii-kovalev for code and docs |
I've put up a pull request to add @vasilii-kovalev! 🎉 |
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
🎉 This PR is included in version 12.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: Create and expose
specialChars
mapWhy:
How:
specialCharMap
specialCharCallbackMap
src/type.js
and create a named export of the constant calledspecialChars
insrc/index.js
typings/index.d.ts
calledspecialChars
specialChars
section toREADME.md
Checklist:
P.S.: I've defined enum because
const
is not allowed inindex.d.ts
. Ifsrc/type.js
could be written in TypeScript, it could be possible to use a const assertion syntax instead, so thespecialCharMap
constant could be a single source of truth.