fix: exclude hidden type inputs from focusable selector #467
Conversation
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 476 476
Branches 132 132
=========================================
Hits 476 476
Continue to review full report at Codecov.
|
| @@ -219,7 +219,7 @@ function setSelectionRangeIfNecessary( | |||
| } | |||
|
|
|||
| const FOCUSABLE_SELECTOR = [ | |||
| 'input:not([disabled])', | |||
| 'input:not([type=hidden]):not([disabled])', | |||
There was a problem hiding this comment.
Actually, the hidden attribute could be applied to any element. I think we need to add this to all of the selectors here.
There was a problem hiding this comment.
I just checked in Chrome: <div tabIndex="0" type="hidden"> has no effect.
I don't think it is specified to have any meaning on other elements.
There was a problem hiding this comment.
Oh, duh. I was thinking about the hidden attribute itself (like <button hidden="true">).
But yeah, the hidden type is what we're dealing with here and that works fine. Thanks!
I wonder whether we should/need to fix how we handle the hidden attribute though 🤔
I'll merge this as-is. Thanks!
There was a problem hiding this comment.
@lazytype, I mean, I'm happy to merge after you sort out @ph-fritsche's comment https://github.com/testing-library/user-event/pull/467/files#r504487490
|
@all-contributors please add @lazytype for code and tests |
|
I've put up a pull request to add @lazytype! 🎉 |
|
🎉 This PR is included in version 12.1.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…ary#467) * fix(tab): exclude hidden type inputs from focusable selector * make test leaner Co-authored-by: Michael Mitchell <michael.mitchell@mongodb.com>
fix #466
What:
tabattempts to focus hidden type inputsWhy: Hidden-type input elements do not receive tab focus in common browsers, but
tabfails to exclude them from its tab-able element list which produces incorrect behavior.How: Update
FOCUSABLE_SELECTORto exclude hidden inputs.Checklist: