Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add exports field #1022

Merged
merged 1 commit into from Aug 4, 2022
Merged

fix(build): add exports field #1022

merged 1 commit into from Aug 4, 2022

Conversation

ph-fritsche
Copy link
Member

What:

Add exports field

Why:

Missing exports field breaks native ESM import.
See #1021

How:

Updated script to always generate exports field when creating a dual-build.

Checklist:

  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f35299d:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1022 (f35299d) into main (ff121ff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1022   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         2076      2076           
  Branches       702       702           
=========================================
  Hits          2076      2076           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ph-fritsche ph-fritsche merged commit 7839e29 into main Aug 4, 2022
@ph-fritsche ph-fritsche deleted the fix-build branch August 4, 2022 22:03
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 14.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant