Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prevent false-positive with fake timers #1010

Merged
merged 1 commit into from Aug 2, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Prevent false-positive test due to slow test environment.

Why:

Sometimes the execution is delayed just enough to make this assertion fail.

Checklist:

  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c5f272:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1010 (6c5f272) into main (1c156c2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         1876      1876           
  Branches       679       679           
=========================================
  Hits          1876      1876           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ph-fritsche ph-fritsche merged commit c6aafb7 into main Aug 2, 2022
@ph-fritsche ph-fritsche deleted the test-racing branch August 2, 2022 12:24
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🎉 This PR is included in version 14.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant