test: Backport tests using the full timer matrix #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6ce4fa:
|
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #962 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 140 140
Branches 28 28
=========================================
Hits 140 140 Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 13.0.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 12.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds tests for
waitFor,waitForElementToBeRemovedandfindByacross all supported timer implementations (real timers, jest legacy fake timers, jest modern fake timers).Why:
These offer a more granular coverage that's required for #937.
The new tests are also the only tests that would trigger a missing act warning if we were to remove the
asyncWrapper.How:
Backport tests from #937 and convert the class component to a function component. With a class component we'd still not get a missing act warning.
Checklist:
[ ]Documentation added to thedocs site
[ ]TypeScript definitions updated