Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update @testing-library/dom #931

Merged
merged 1 commit into from Jun 13, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 12, 2021

Closes #918

BREAKING CHANGE: Remove waitForElement. <style />, <script /> and comment nodes are now ignored by default in pretty-dom.

What:

Why:

Propagate changes in /dom to /react users

How:

Bump @testing-library/dom to latest alpha

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@eps1lon eps1lon added the BREAKING CHANGE This change will require a major version bump label Jun 12, 2021
@eps1lon eps1lon linked an issue Jun 12, 2021 that may be closed by this pull request
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 66542da:

Sandbox Source
React Configuration
react-testing-library-examples Configuration
react-testing-library demo Issue #918

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #931 (66542da) into alpha (42dad78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #931   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dad78...66542da. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review June 12, 2021 09:55
@eps1lon eps1lon merged commit 05c7421 into testing-library:alpha Jun 13, 2021
@eps1lon eps1lon deleted the fix/bump-dtl branch June 13, 2021 16:02
@github-actions
Copy link

🎉 This PR is included in version 12.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not play well with jest 27
1 participant