Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ignore React 18 legacy root deprecation warnings #928

Merged
merged 2 commits into from Jun 12, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 12, 2021

What:

Fix test failures on next and experimental jobs

Why:

The tests are failing in a way that isn't actionable for us at the moment

How:

Ignore ReactDOM.render and ReactDOM.hydrate deprecation warnings

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e891310:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #928 (e891310) into main (7957355) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #928   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7957355...e891310. Read the comment docs.

@eps1lon eps1lon marked this pull request as draft June 12, 2021 08:50
@eps1lon eps1lon marked this pull request as ready for review June 12, 2021 09:00
@eps1lon eps1lon merged commit 487eb85 into testing-library:main Jun 12, 2021
@eps1lon eps1lon deleted the test/fix-react-alpha branch June 12, 2021 09:05
eps1lon added a commit to eps1lon/react-testing-library that referenced this pull request Jun 12, 2021
@github-actions
Copy link

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant