Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump kcd-scripts to 11.x #921

Merged
merged 4 commits into from Jun 8, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 8, 2021

Targetting alpha since @testing-library/dom@latest is not compatible with jest 27

What:

Update npm run validate dependencies

Why:

To stay up-to-date with latest dependencies

How:

Bump kcd-scripts incrementally up until 11.x. Each commits bumps by a major so review by commit is advised.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1c9869:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@eps1lon eps1lon marked this pull request as ready for review June 8, 2021 08:50
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #921 (d1c9869) into main (830da02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #921   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 875ee5b...d1c9869. Read the comment docs.

Comment on lines -64 to 65
setImmediate(() => {
Promise.resolve().then(() => {
microTaskSpy()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setImmediate is no longer available in jsdom. Promise.resolve() does the same thing considering the naming microTaskSpy

@@ -2,7 +2,7 @@ let act, asyncAct

beforeEach(() => {
jest.resetModules()
act = require('..').act
act = require('../pure').act
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. would include automatic cleanup i.e. setting up beforeEach and afterEach hooks. This throws now in jest.

@eps1lon eps1lon changed the base branch from main to alpha June 8, 2021 11:52
@eps1lon eps1lon merged commit c1a931d into testing-library:alpha Jun 8, 2021
@eps1lon eps1lon deleted the chore/bump-kcd-scripts branch June 8, 2021 18:05
@github-actions
Copy link

🎉 This PR is included in version 12.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant