Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust .travis to install latest npm #812

Merged
merged 1 commit into from Oct 30, 2020

Conversation

kentcdodds
Copy link
Member

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b813bb:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #812 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #812   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2806fc...4b813bb. Read the comment docs.

@nickmccurdy
Copy link
Member

Out of curiosity, are we still supporting Node versions that don't support npm 7?

Copy link

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but this way you don’t have to keep track of which npm supports which node.

@kentcdodds kentcdodds merged commit 1fc1746 into master Oct 30, 2020
@kentcdodds
Copy link
Member Author

Thanks @ljharb!

@all-contributors please add @ljharb for review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @ljharb! 🎉

@kentcdodds kentcdodds deleted the pr/improve-travis-npm branch October 30, 2020 15:17
@testing-library-bot
Copy link

🎉 This PR is included in version 11.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickmccurdy
Copy link
Member

FYI: You can use the Add Suggestion button on GitHub (or git commit --author "..." to commit changes manually) to commit something authored by someone else. git/GitHub will display both users on the commit.

@nickmccurdy
Copy link
Member

nickmccurdy commented Nov 14, 2020

@kentcdodds This installs npm 6, not 7. Is that intentional or should we adjust Travis/actions to use npm 7? Also applies to Vue Testing Library.

@ljharb
Copy link

ljharb commented Nov 14, 2020

That’s because npm 7 isn’t marked latest yet.

@nickmccurdy
Copy link
Member

I'm aware. I wasn't sure if Kent wanted to specifically use 6 or 7, or just have the fix for #809.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants