Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger ongot-/onlostpointercapture when calling got-/lostpointercapture #786

Merged
merged 5 commits into from Sep 13, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 13, 2020

What:

Calling fireEvent.gotPointerCapture or fireEvent.lostPointerCapture should trigger their corresponding React event listeners.

Why:

Reveals issues with gotpointercapture and lostpointerapture

How:

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@eps1lon eps1lon changed the title test: Add full PointerEvent test suite fix: Trigger ongot-/onlostpointercapture when calling got-/lostpointercapture Sep 13, 2020
@eps1lon eps1lon marked this pull request as ready for review September 13, 2020 17:28
@eps1lon eps1lon added the bug Something isn't working label Sep 13, 2020
@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #786 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #786   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          117       117           
  Branches        16        16           
=========================================
  Hits           117       117           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732f3a1...138e1ef. Read the comment docs.

@eps1lon eps1lon merged commit c546a6f into testing-library:master Sep 13, 2020
@eps1lon eps1lon deleted the test/pointer-events branch September 13, 2020 18:33
@testing-library-bot
Copy link

🎉 This PR is included in version 11.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants