Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave #784

Merged
merged 5 commits into from Sep 13, 2020

Conversation

karthick3018
Copy link
Contributor

Pointer events added:

Existing code doesn't include pointer events:

Similar to the mouse events:

Checklist:

  • Documentation added to the N/A
    docs site
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b106fa:

Sandbox Source
React Configuration
kentcdodds/react-testing-library-examples Configuration

@kentcdodds
Copy link
Member

Thanks for this! Could we get some tests please?

@karthick3018
Copy link
Contributor Author

karthick3018 commented Sep 13, 2020

Thanks for this! Could we get some tests please?

hey @kentcdodds nice to hear from you! added a passing test case

@codecov
Copy link

codecov bot commented Sep 13, 2020

Codecov Report

Merging #784 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #784   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          109       117    +8     
  Branches        16        16           
=========================================
+ Hits           109       117    +8     
Impacted Files Coverage Δ
src/fire-event.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865c4fd...8b106fa. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think @eps1lon?

@eps1lon eps1lon changed the title This will solve #783 fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave Sep 13, 2020
@eps1lon eps1lon merged commit c7b5622 into testing-library:master Sep 13, 2020
@eps1lon
Copy link
Member

eps1lon commented Sep 13, 2020

@all-contributors add @karthick3018 for code

@allcontributors
Copy link
Contributor

@eps1lon

I've put up a pull request to add @karthick3018! 🎉

@testing-library-bot
Copy link

🎉 This PR is included in version 11.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants